Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non-interactive installation #932

Merged
merged 3 commits into from
Jul 9, 2019
Merged

allow non-interactive installation #932

merged 3 commits into from
Jul 9, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Jul 8, 2019

Description

Fixes #928

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.1 milestone Jul 8, 2019
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #932 into master will increase coverage by <.01%.
The diff coverage is 81.81%.

@@             Coverage Diff              @@
##             master     #932      +/-   ##
============================================
+ Coverage     94.19%   94.19%   +<.01%     
- Complexity     2604     2605       +1     
============================================
  Files           278      278              
  Lines          8092     8094       +2     
============================================
+ Hits           7622     7624       +2     
  Misses          470      470
Impacted Files Coverage Δ Complexity Δ
src/Command/InstallCommand.php 67.54% <81.81%> (+0.57%) 36 <4> (+1) ⬆️

@kevinpapst kevinpapst marked this pull request as ready for review July 9, 2019 01:03
@kevinpapst kevinpapst merged commit eb4aa23 into master Jul 9, 2019
@kevinpapst kevinpapst deleted the install-command branch July 9, 2019 01:03
@lock
Copy link

lock bot commented Sep 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QUESTION: Graceful way to check for several things on startup
1 participant