Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"popover" columnFilterDisplayMode does not seem to work with filterVariant: select #269

Closed
1 task done
ericblade opened this issue Feb 9, 2024 · 7 comments
Closed
1 task done
Assignees
Labels
V2 Issue with MRT V2

Comments

@ericblade
Copy link

mantine-react-table version

2.0.0-alpha.16

react & react-dom versions

18.2.0

Describe the bug and the steps to reproduce it

The popover comes up, but selecting anything in the select drop down, or entering text, fails to actually run the filter.

This is also visible in the popover example in the documentation.

Minimal, Reproducible Example - (Optional, but Recommended)

https://v2.mantine-react-table.com/docs/guides/column-filtering#alternate-column-filtering-demo

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

None

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@alessandrojcm
Copy link
Collaborator

Hey, can you try with the beta.0 and confirm is this is still an issue?

@alessandrojcm alessandrojcm added the V2 Issue with MRT V2 label Mar 18, 2024
@alessandrojcm alessandrojcm self-assigned this Mar 18, 2024
@ericblade
Copy link
Author

If the documentation site has been updated, then it's still an issue. I hope to have some time to check it out on my personal app this weekend sometime. Thanks for the notice, and I'll let you know as soon as I have a chance.

@waltershewmake
Copy link
Contributor

I am experiencing this issue on 2.0.0-beta.1

@waltershewmake
Copy link
Contributor

waltershewmake commented May 5, 2024

Presumably, this is because there is no way to stop event propagation from the Mantine Select field dropdown without rewriting it using a custom ComboBox implementation (as far as I am aware). For the same reason, this issue is likely also present in the autocomplete filter variant, which uses a ComboBox under the hood as well.

@waltershewmake
Copy link
Contributor

Actually, I just found a solution. I will fork and propose a fix. In MRT_FilterTextInput you can wrap the entire return block with

<div onMouseDown={(e) => e.stopPropagation()}>
...
</div>

@alessandrojcm
Copy link
Collaborator

Merged, thanks @waltershewmake

@ericblade
Copy link
Author

Apologies it took me a few .. months... :( to check in on this, just got my app back up now that i've got some time off from work. Time now to update all the dependencies, and I'll check this out. If it's still a problem, I'll reopen.

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Issue with MRT V2
Projects
None yet
Development

No branches or pull requests

3 participants