Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input not recognised when typing too early. #13

Closed
tessarakt opened this issue Nov 29, 2019 · 8 comments
Closed

Input not recognised when typing too early. #13

tessarakt opened this issue Nov 29, 2019 · 8 comments
Labels
bug Something isn't working

Comments

@tessarakt
Copy link

tessarakt commented Nov 29, 2019

Version: 2.0.0pre1

Steps to reproduce:

  1. Press Shift-G.
    => First, the Buttons "Move", "Copy" and "Goto" and a text box will appear.
  2. Immediately type something.

Expected result: The typed string is entered into the text box.
Actual result: The typed string does not appear in the text box. Instead, it is apparently still processed by the folder list, and can trigger (via keyboard shortcuts) actions like watching a thread.

@tessarakt tessarakt changed the title Input not recognised when tyloiu Input not recognised when typing too early. Nov 29, 2019
@bbceg
Copy link

bbceg commented Dec 5, 2019

Just for the record, this appears to be a problem with previous versions. I'm running 1.6.1 on Thunderbird 60.9.1 and if you press Shift+M and start typing before the search box/folder list appears, you can unwittingly apply all manner of properties to your emails (as you have described @tessarakt ). Is there a chance this is more of a Thunderbird issue rather than a plugin issue and if so is it worth raising this elsewhere?

@kewisch
Copy link
Owner

kewisch commented Dec 16, 2019

Probably a timing issue with the addon actually. For 2.x I might have to reduce the initialization time before the textbox is displayed and focused. If that is not enough I might be able to fix it in Thunderbird. For 1.x I could probably do more by stopping keypresses after the shift+[MGY] keys are used. This is a good tip though, I saw this much more in 2.x

@bbceg
Copy link

bbceg commented Dec 16, 2019

This is a little off topic but I've been using 2.0 consistently for about a week (although exclusively the move functionality) and with the exception of this issue, 2.0 is working well for me on Thunderbird 68.3.0 on Windows 10. Not sure if this counts as "testing" but thought I'd post in case it helped!

Also off topic, but why are there two pre-release versions (1.7 and 2.0)? Would it be more helpful to test with one instead of the other?

Let me know if queries / comments like this would be better posted elsewhere. I wasn't sure where else made sense.

@kewisch
Copy link
Owner

kewisch commented Dec 16, 2019

1.7 is built on the same codebase as 1.6 and 2.0 is a rewrite. I added 1.7 because there were still some bugs in Thunderbird that don't make me confident I could soon release it as a replacement.

Based on feedback I got I'm likely going to release 1.7 soon, so if you like please do continue with 2.0.

@kewisch kewisch added bug Something isn't working MailExtension labels Jan 6, 2020
@sbsrouteur
Copy link

Hi,

I think I have the same issue, when I click the menu to use quickfolder to move messages the popup shows up. I start typing and the menu will randomly go away ignoring input which is there used to mess my mailboxes, since most lettres trigger an action.

Is there a workaround , as this is super annoying (even though extension is great)

@bbceg
Copy link

bbceg commented Feb 4, 2020

Not wildly helpful, but I recently upgrade my PC (10 year old i7 but with an upgraded SSD) to a recent core i5 + NVMe SSD and this issue has all but disappeared. I appreciate buying a new PC is probably overkill for this issue alone...

@sbsrouteur
Copy link

If it may help, when logging my comment I found out that Shift+M would pop-up the menu as well and it does not seem to make the problem. It only appears when going through the context menu via right click on a message in the message list panel.

@kewisch
Copy link
Owner

kewisch commented Aug 20, 2023

I think what we have in v2 is all I can do here. If there is typing before the popup window complets opening, I don't think I can capture that input. You'll have to train your muscle memory to pause for a few milliseconds before typing. If someone has a specific idea for improvement, a pull request is very welcome!

@kewisch kewisch closed this as completed Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants