Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: option to auto explode AckRequests and answers #85

Closed
krezreb opened this issue Mar 26, 2020 · 3 comments
Closed

Feature Request: option to auto explode AckRequests and answers #85

krezreb opened this issue Mar 26, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@krezreb
Copy link
Contributor

krezreb commented Mar 26, 2020

While I understand the point of having AckRequests and Acks in chat channels, in certain cases it might be nice to have them auto explode. For example, if I need to track which users signed in, the bot's response with the certificate is enough. Once the bot has given this cert, I really don't care about the Ack messages.

It would be nice for these Ack messages to auto explode. The default could, for example, be 5minutes, and of course be configurable

@mmou mmou added the enhancement New feature or request label Apr 20, 2020
@mmou mmou added the good first issue Good for newcomers label Apr 20, 2020
@joshblum
Copy link
Member

@krezreb you can set an exploding retention policy on the conversation and the client will respect the policy and apply the default. @mmou we can likely close keybase/go-keybase-chat-bot#68 as a result

@mmou
Copy link
Contributor

mmou commented Apr 20, 2020

Setting the conversation retention policy to is a decent alternative, but perhaps the intention of this request is to be able to retain the Signature_Request and Signature_Response messages, and only explode the AckRequest and Ack messages.

If you set the policy to explode all messages, you can still audit logins by looking at your SSH CA logs at LOG_LOCATION.

@mmou
Copy link
Contributor

mmou commented Apr 28, 2020

deprioritizing until there is a reason why the above suggestion doesn't work

@mmou mmou closed this as completed Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants