Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File edits do not show up on Windows device after saving on OS X device (in Team folder) #11373

Open
localmisfit opened this issue Apr 11, 2018 · 19 comments
Labels

Comments

@localmisfit
Copy link

I was testing file edits on a Word doc with someone who has a Macbook, and although I saw the first save, once I started adding to the doc and also saving on my end (on Windows), I no longer saw other subsequent edits from the Macbook.

Example of doc contents:

Hey guys! [saved from Macbook - showed up on Windows]

Testing another comment [saved from Windows]

[waited for subsequent saves from Macbook to show up after closing and reopening doc multiple times on Windows.....]

Comment1 from Macbook [did not show up on Windows]

One more comment [saved from Windows - did not show up on Macbook]

Comment2 from Macbook [did not show up on Windows]

[waited again for subsequent saves to show up but they never did]

There were also no new conflicting files in the team folder. Anyone else experience issues with collaboration on files using team folders? This is super important to us as we'd like to use Keybase for file collaboration on a regular basis.

my log id: 4fe024ce600d02d680bfc01c

@localmisfit
Copy link
Author

localmisfit commented Apr 11, 2018

If it helps, this is the file on Windows with some greyed out temp files (which I can't seem to open). Bottom file is the original file we were both trying to edit.

image

@strib strib added the acked label Apr 12, 2018
@strib
Copy link
Contributor

strib commented Apr 12, 2018

@localmisfit can you also please do a keybase log send from the macbook? I'll look at the logs together soon, likely in the morning (PT).

@localmisfit
Copy link
Author

@strib I'll be able to get that to you by PT afternoon. Is there any personal info from device (MacBook) that is contained within log?

@strib
Copy link
Contributor

strib commented Apr 12, 2018

The logs contain file names and file metadata (like sizes and modification times), but none of the actual data from inside the file.

@strib
Copy link
Contributor

strib commented Apr 12, 2018

The macbook log would still be useful when you get a chance and are ok with it, but I did find an issue in the Windows log. It seems like you hit a corner case in our conflict resolution protocol, and Windows gave up trying to resolve the conflict and is now stuck with its current view of the folder. I'm still investigating the bug, but you can fix it by doing this on the Windows machine:

  1. If there's any data in the team folder that only shows up on the Windows machine that you'd like to save, copy it to a safe location on your local disk.
  2. Quit Keybase completely, so that the K drive unmounts.
  3. Move or rename this directory to something else, say backup-7eab6342d9a0d402: %appdata%\Local\Keybase\kbfs_journal\v1\012007f42bd75bc7b3270d51f35f1b28f131-7eab6342d9a0d402.
  4. Restart Keybase.

Now your Windows machine should be in sync with the latest version of the folder.

I'll continue to look into why conflict resolution failed. For the searchable record here's the error in the log:

2018-04-11T14:43:27.316740-07:00 - [DEBU kbfs(CR 7eab6342) conflict_resolver.go:3235] 4ef4 Finished conflict resolution: No chain found for BlockPointer{ID: 0108195d87143200f6e0662d777262be5887df415c52af2566110a748e7b797eb4, KeyGen: 2, DataVer: 3, Context: Context{Creator: d34b4cc458ac3a081cd1804f8d9e1d24}, DirectType: direct}

@localmisfit
Copy link
Author

localmisfit commented Apr 12, 2018

@strib Got it.

Tried sending a log from the Macbook but getting this error:

▶ ERROR API network error: Post https://api-0.core.keybaseapi.com/_/api/1.0/logdump/send.json: dial tcp: lookup api-0.core.keybaseapi.com: no such host

Sent another log from the Windows device just a few minutes ago: 2782e450ccfab770e7c7491c

Along with that, getting errors trying to reopen Keybase on the Macbook:

screen shot 2018-04-12 at 10 16 10 am

@strib
Copy link
Contributor

strib commented Apr 12, 2018

Hmm, seems like the macbook might be having temporary network/DNS issues? Maybe try again? I think we fixed this ugly error message recently...

@localmisfit
Copy link
Author

Alright a restart seems to have cleared things up.

Here's log file from Macbook: b064394ed802a56ecfa1021c

Also interesting that I deleted some folders that I created in the team folder, and although they disappeared from the Windows machine, they still showed up on the Macbook.

@strib
Copy link
Contributor

strib commented Apr 12, 2018

Also interesting that I deleted some folders that I created in the team folder, and although they disappeared from the Windows machine, they still showed up on the Macbook.

@localmisfit did you delete them from the Windows machine or the macbook?

@strib
Copy link
Contributor

strib commented Apr 12, 2018

@localmisfit the logs you just sent are from a brand new device that you just provisioned today -- it couldn't have been involved in any of the tests from yesterday. Can you do a log send from yesterday's device, or is it lost?

@strib
Copy link
Contributor

strib commented Apr 12, 2018

(Or maybe you sent the logs as a user that was just added to the device today -- if it's the same physical macbook, maybe log in as the user you were using yesterday and try keybase log send again?)

@localmisfit
Copy link
Author

@localmisfit did you delete them from the Windows machine or the macbook?

I deleted from the Windows machine.

@localmisfit
Copy link
Author

I'm sending the Macbook logs from a different Macbook than yesterday because I thought it would be alright since I'm encountering the same issue. Let me see if I can get a log send from the Macbook from yesterday.

@strib
Copy link
Contributor

strib commented Apr 12, 2018

I deleted from the Windows machine.

That's why -- the Windows machine was stuck in a state where it wasn't sharing any updates with anyone else. The deletes never made it to our servers, and so your macbooks won't be able to see them.

Let me see if I can get a log send from the Macbook from yesterday.

It's ok if you can't, I'm not sure it's going to give me any more useful info. There's only some small chance it does.

More interesting will be when you get a chance to run the steps above on your Windows machine and see if that fixes the issues.

@localmisfit
Copy link
Author

Ok let me try the steps above. Didn't see that earlier.

@localmisfit
Copy link
Author

That did the trick! I can see updates to the file and "deleted" folders. Will do some more testing to see if I get any more conflicts.

@localmisfit
Copy link
Author

Ok, so I just tested again (basically entering different data from two different machines - Macbook and Windows and pressing Save simultaneously) and now I'm seeing the conflict file. Looks like whatever the bug was is not showing up now.

@strib
Copy link
Contributor

strib commented Apr 12, 2018

Great! Yeah it must be pretty rare, as I haven't seen one like that lately. I'll file an internal issue and hope to make some progress on it.

@localmisfit
Copy link
Author

Great! Thanks a bunch. I'll let you know if it happens to come up again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants