-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the gconf dependency on Arch Linux #23909
Conversation
In the usual Arch Linux workflow, this is a generated file. However, generating it requires the `makepkg` tool, which is difficult to run on anything other than Arch Linux. To avoid that dependency, we've checked in this generated file as another template. However, as a predictable consequence, it's gotten out of sync with the PKGBUILD file it's supposedly generated from. These changes bring it back into sync. One alternative to this whole setup, would be to just run a Docker image for Arch Linux, and to legitimately generate this file. If that would be convenient in the current build environment, it's worth considering.
This was suggested in https://aur.archlinux.org/packages/keybase-bin/#comment-723637.
What distros do you currently use in the release toolchain? |
gconf was removed from electron here: electron/electron#19498
All these should be removed. It's not specific to Arch Linux. |
[It's been a while since I worked at Keybase, so I'll let someone who's up to speed on the build pipeline chime in.] |
@oconnor663 I think you should also edit
It would be great if you could make the modifications and run the tests for the ubuntu images (no ubuntu installation needed, instructions here) |
Thanks! |
I'll defer to folks who use the other distros to make those changes. I'm not very confident that I'd test things properly. |
I've updated the keybase-git AUR package with the same change. |
This was suggested in https://aur.archlinux.org/packages/keybase-bin/#comment-723637.
I just tested it on my machine, and the Keybase client starts successfully without gconf.
f6bd8dc updates some stale metadata in the .SRCINFO file.
In the usual Arch Linux workflow, this is a generated file. However,
generating it requires the
makepkg
tool, which is difficult to run onanything other than Arch Linux. To avoid that dependency, we've checked
in this generated file as another template. However, as a predictable
consequence, it's gotten out of sync with the PKGBUILD file it's
supposedly generated from. These changes bring it back into sync.
One alternative to this whole setup, would be to just run a Docker image
for Arch Linux, and to legitimately generate this file. If that would be
convenient in the current build environment, it's worth considering.