getParameterCount() can be used instead of getParameterTypes().length and getParameters().length

[clara0]

Description

Replace occurrences of getParameterTypes().length and getParameters().length with getParameterCount().

Targets
    Occurrences of 'getParameterTypes().length' in Project
Found Occurrences in Project  (9 usages found)
    Production  (8 usages found)
        Unclassified  (8 usages found)
            keycloak-common  (2 usages found)
                org.keycloak.common.util.reflections  (2 usages found)
                    Types.java  (2 usages found)
                        isCompatible(Method, Method)  (2 usages found)
                            166 if (method.getParameterCount() != intfMethod.getParameterTypes().length) return false;
                            168 for (int i = 0; i < method.getParameterTypes().length; i++)
            keycloak-ldap-federation  (1 usage found)
                org.keycloak.storage.ldap  (1 usage found)
                    LDAPUtils.java  (1 usage found)
                        getUserModelProperties()  (1 usage found)
                            326 && m.getParameterTypes().length > 0) {
            keycloak-oidc-client-adapter-pom  (1 usage found)
                adapters/oidc/as7-eap6/as7-adapter-spi/src/main/java/org/keycloak/adapters/jbossweb  (1 usage found)
                    JBossWebPrincipalFactory.java  (1 usage found)
                        findJBossGenericPrincipalConstructor()  (1 usage found)
                            166 if (c.getParameterTypes().length == 9 &&
            keycloak-server-spi-private  (4 usages found)
                org.keycloak.models.utils.reflection  (4 usages found)
                    MethodPropertyImpl.java  (4 usages found)
                        MethodPropertyImpl(Method)  (2 usages found)
                            52 } else if (method.getParameterTypes().length > 0) {
                            62 } else if (method.getParameterTypes().length != 1) {
                        getSetterMethod(Class<?>, String)  (1 usage found)
                            154 if (methodName.startsWith(SETTER_METHOD_PREFIX) && method.getParameterTypes().length == 1) {
                        getGetterMethod(Class<?>, String)  (1 usage found)
                            166 if (method.getParameterTypes().length == 0) {
    Test  (1 usage found)
        Unclassified  (1 usage found)
            integration-arquillian-tests-base  (1 usage found)
                org.keycloak.testsuite.migration.cluster  (1 usage found)
                    MultiVersionClusterTest.java  (1 usage found)
                        createCacheAndGetFromServer(ContainerInfo)  (1 usage found)
                            279 .anyMatch(c -> c.getParameterTypes().length == 0 )) {

Targets
    Occurrences of 'getParameters().length' in Project
Found Occurrences in Project  (1 usage found)
    Test  (1 usage found)
        Unclassified  (1 usage found)
            integration-arquillian-tests-base  (1 usage found)
                org.keycloak.testsuite.admin  (1 usage found)
                    PermissionsTest.java  (1 usage found)
                        assertGettersEmpty(Object, String...)  (1 usage found)
                            1976 if (m.getParameters().length == 0 && m.getName().startsWith("get") && !ignoreList.contains(m.getName())) {

Discussion

No response

Motivation

getParameterTypes().length and getParameters().length are inefficient because they create an array clone, while getParameterCount() directly returns the length.

Details

No response

[ahus1]

Thanks for reporting this, I see you already prepared a PR for this.

I wonder: did you find this via a performance test, or did it have in impact for you? I'd like to understand more about the background/motivation for this PR. Thanks!

[clara0]

@ahus1 I noticed this problem initially in wildfly when taking a look at the code, then saw that other repositories also had the same issue. While I don't think this issue is particularly significant enough to show up on performance tests, the array clones put a strain on the GC.