Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Saml AuthnContextDecl in SAML Assertion is ommitted #10743

Closed
yoannguion opened this issue Mar 14, 2022 · 0 comments · Fixed by #10750
Closed

Saml AuthnContextDecl in SAML Assertion is ommitted #10743

yoannguion opened this issue Mar 14, 2022 · 0 comments · Fixed by #10750
Labels
area/saml Indicates an issue on SAML area impact/low kind/bug Categorizes a PR related to a bug
Milestone
18.0.0

Comments

@yoannguion
Copy link
Contributor

Describe the bug

Hello,

I have wroten a custom saml Extension in keycloak where i customize saml AuthnContext.

But the AuthnContextDecl (https://github.com/keycloak/keycloak/blob/main/saml-core-api/src/main/java/org/keycloak/dom/saml/v2/assertion/AuthnContextDeclType.java) i had is ignored during the Assertion serialization in Xml.

There is a bug in the SAMLAssertionWriter

I will do a PR for the change.

The bug is present in a lot of version, i reproduce the bug with 11, 15, 16, 17

Version

17

Expected behavior

The AuthnContextDecl added in AuthnContext must be included in serialized Assertion

Actual behavior

The AuthnContextDecl added in AuthnContext is not included in serialized Assertion

How to Reproduce?

No response

Anything else?

No response
@yoannguion yoannguion added kind/bug Categorizes a PR related to a bug status/triage labels Mar 14, 2022
yoannguion pushed a commit to yoannguion/keycloak that referenced this issue Mar 15, 2022
include AuthnContextDecl if present during SAML Assertion Serialization
4800233 
Closes keycloak#10743
@yoannguion yoannguion mentioned this issue Mar 15, 2022
Merged
@hmlnarik hmlnarik added area/saml Indicates an issue on SAML area impact/low and removed status/triage labels Mar 15, 2022
hmlnarik pushed a commit that referenced this issue Mar 16, 2022
@hmlnarik
include AuthnContextDecl if present during SAML Assertion Serialization
3d47012 
Closes #10743
@stianst stianst added this to the 18.0.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/saml Indicates an issue on SAML area impact/low kind/bug Categorizes a PR related to a bug
Projects
None yet
Milestone
18.0.0
Development

Successfully merging a pull request may close this issue.

include AuthnContextDecl if present during SAML Assertion Serialization yoannguion/keycloak
3 participants
@yoannguion @stianst @hmlnarik