Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make KeycloakDeploymentBuilder initialize CryptoIntegration #15767

Closed
rgala opened this issue Nov 30, 2022 · 0 comments · Fixed by #15768
Closed

Make KeycloakDeploymentBuilder initialize CryptoIntegration #15767

rgala opened this issue Nov 30, 2022 · 0 comments · Fixed by #15768
Labels
area/core kind/bug Categorizes a PR related to a bug
Milestone

Comments

@rgala
Copy link
Contributor

rgala commented Nov 30, 2022

Area

core

Describe the bug

CryptoIntegration not initialized when calling build(AdapterConfig adapterConfig) on KeycloakDeploymentBuilder

Version

20.0.1

Expected behavior

CryptoIntegration.init(KeycloakDeploymentBuilder.class.getClassLoader());

should be called in

    public static KeycloakDeployment build(AdapterConfig adapterConfig) {
        CryptoIntegration.init(KeycloakDeploymentBuilder.class.getClassLoader());
        return new KeycloakDeploymentBuilder().internalBuild(adapterConfig);
    }

Actual behavior

CryptoIntegration.init is not called

How to Reproduce?

Call KeycloakDeploymentBuilder.build(adapterConfig)

Anything else?

No response

@rgala rgala added kind/bug Categorizes a PR related to a bug status/triage labels Nov 30, 2022
@ghost ghost added the area/core label Nov 30, 2022
rgala added a commit to rgala/keycloak that referenced this issue Nov 30, 2022
Initialize CryptoIntegration before building KeycloakDeploymentBuilder, same way as in public static KeycloakDeployment build(InputStream is) method

Closes keycloak#15767
@ghost ghost removed the status/triage label Dec 2, 2022
@mposolda mposolda added this to the 21.0.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core kind/bug Categorizes a PR related to a bug
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants