Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MySQL connector artifact should be ignored #28001

Closed
2 tasks done
mabartos opened this issue Mar 18, 2024 · 1 comment · Fixed by #28003 or #28005
Closed
2 tasks done

MySQL connector artifact should be ignored #28001

mabartos opened this issue Mar 18, 2024 · 1 comment · Fixed by #28003 or #28005
Assignees
@mabartos
Labels
area/dist/quarkus impact/low kind/bug Categorizes a PR related to a bug release/24.0.2 release/25.0.0 team/cloud-native
Milestone
25.0.0

Comments

@mabartos
Copy link
Contributor

Before reporting an issue

  • I have read and understood the above terms for submitting issues, and I understand that my issue may be closed without action if I do not follow them.

Area

dist/quarkus

Describe the bug

For particular artifacts, we mark them as ignored for class loaders based on the configuration. For instance, when PostgreSQL DB is used, we ignore artifacts for all other DB vendors supported by Keycloak. For more information, see #22442

For MySQL, the groupId and artifactId have changed, but we didn't reflect it for the ignored artifacts.
For more information, see #26788.

Version

999

Regression

  • The issue is a regression

Expected behavior

The MySQL connector JAR is ignored

Actual behavior

The MySQL connector JAR is NOT ignored

How to Reproduce?

Check heap dump

Anything else?

No response
@mabartos mabartos added kind/bug Categorizes a PR related to a bug impact/low area/dist/quarkus labels Mar 18, 2024
@mabartos mabartos added this to the 25.0.0 milestone Mar 18, 2024
@mabartos mabartos self-assigned this Mar 18, 2024
@mabartos
Copy link
Contributor Author

We could also implement an enhancement users would be notified about the non-existence of the JAR. Created issue: #28002

mabartos added a commit to mabartos/keycloak that referenced this issue Mar 18, 2024
@mabartos
MySQL connector artifact should be ignored
149e06b 
Fixes keycloak#28001

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos mabartos mentioned this issue Mar 18, 2024
Merged
mabartos added a commit to mabartos/keycloak that referenced this issue Mar 18, 2024
@mabartos
MySQL connector artifact should be ignored
92308c5 
Fixes keycloak#28001

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos mabartos mentioned this issue Mar 18, 2024
Merged
@mabartos mabartos linked a pull request Mar 18, 2024 that will close this issue
MySQL connector artifact should be ignored #28005
Merged
mabartos added a commit that referenced this issue Mar 19, 2024
@mabartos
MySQL connector artifact should be ignored (#28003)
0892689 
Fixes #28001

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
mabartos added a commit that referenced this issue Mar 19, 2024
@mabartos
MySQL connector artifact should be ignored (#28005)
1ee0d28 
Fixes #28001

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this issue Mar 22, 2024
@mabartos @ahus1
MySQL connector artifact should be ignored (keycloak#28003)
9980b9e 
Fixes keycloak#28001

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mabartos mabartos

Labels
area/dist/quarkus impact/low kind/bug Categorizes a PR related to a bug release/24.0.2 release/25.0.0 team/cloud-native
Projects
Keycloak: Quarkus distribution
Status: Done
Milestone
25.0.0
1 participant
@mabartos