Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing version overrides and further aligning with quarkus versions #26788

Merged
merged 6 commits into from Feb 7, 2024

Conversation

shawkins
Copy link
Contributor

@shawkins shawkins commented Feb 5, 2024

This further aligns us to quarkus versions and removes some test overrides where we can use the quarkus version.

closes #26535

cc @Pepo48 @vmuzikar

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Thank you for this PR!

I wonder if we still need to keep the explicitly set versions for resteasy, db drivers and elytron. Can't we just rely on Quarkus BOM with those too?

@shawkins
Copy link
Contributor Author

shawkins commented Feb 6, 2024

I wonder if we still need to keep the explicitly set versions for resteasy, db drivers and elytron. Can't we just rely on Quarkus BOM with those too?

No, we make use of all of those versions in some way that is not covered by the bom import. There's some description of that in the issue.

Copy link
Contributor

@Pepo48 Pepo48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @shawkins.

Copy link
Contributor

@vmuzikar vmuzikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawkins Ah, right, thanks!

@keycloak/store Do you want to review as well since this concerns DB drivers?

@abstractj abstractj requested a review from a team February 7, 2024 16:51
Copy link
Contributor

@ahus1 ahus1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the store team. Thank you for this change!

@vmuzikar vmuzikar merged commit 402c7d9 into keycloak:main Feb 7, 2024
67 checks passed
cavuugroup pushed a commit to cavuugroup/keycloak that referenced this pull request Feb 8, 2024
…keycloak#26788)

* elevating wildfly-elytron-http-oidc version management

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* removing testing dependency overrides

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* further version aligment with quarkus

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* adding a resteay-core-spi that can be overriden

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* removing hamcrest override

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* aligning with 3.7.1

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

---------

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Signed-off-by: Krzysztof Walczewski <kwalczewski@gmail.com>
ahus1 pushed a commit to ahus1/keycloak that referenced this pull request Mar 22, 2024
…keycloak#26788)

* elevating wildfly-elytron-http-oidc version management

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* removing testing dependency overrides

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* further version aligment with quarkus

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* adding a resteay-core-spi that can be overriden

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* removing hamcrest override

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

* aligning with 3.7.1

Signed-off-by: Steve Hawkins <shawkins@redhat.com>

---------

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post Quarkus 3.7 dependency alignment
4 participants