Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parent versions of WildFly for Galleon Feature Pack #20089

Closed
wants to merge 1 commit into from

Conversation

mabartos
Copy link
Contributor

@mabartos mabartos commented May 2, 2023

@pskopek Do we need to have explicitly specified WildFly versions? We can use already fixed global versions of deps/plugins, right?

I've encountered it during solving possible issues with the saml-adapter-galleon-pack in the build pipeline.

@ghost
Copy link

ghost commented May 2, 2023

Unreported flaky test detected

If the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.transaction.StorageTransactionTest#testLockObjectForModificationById

Keycloak CI - Store Model Tests

java.lang.AssertionError: 

Expected: (not null and ((an instance of org.keycloak.models.ModelException and exception with cause (an instance of jakarta.persistence.PessimisticLockException or an instance of org.hibernate.PessimisticLockException)) or an instance of org.keycloak.models.locking.LockAcquiringTimeoutException))
     but: ((an instance of org.keycloak.models.ModelException and exception with cause (an instance of jakarta.persistence.PessimisticLockException or an instance of org.hibernate.PessimisticLockException)) or an instance of org.keycloak.models.locking.LockAcquiringTimeoutException) was <java.lang.RuntimeException: Waiting for the operation to finish timed out>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
...

Report flaky test

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@ASzc
Copy link
Contributor

ASzc commented Jun 23, 2023

Seems fine to me, best if Peter took a look at this though, was his work

@pskopek
Copy link
Contributor

pskopek commented Aug 31, 2023

@mabartos The changes in this PR are part of #22824.
Can you close this PR, please?

@mabartos
Copy link
Contributor Author

@pskopek Great! Sure

@mabartos mabartos closed this Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants