Support EAP8 with SAML Adapter Galleon Feature Pack #22824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2023
fjuma
reviewed
Aug 30, 2023
| <wildfly.build-tools.version>1.2.13.Final</wildfly.build-tools.version> | ||
| <wildfly.core.version>19.0.1.Final</wildfly.core.version> | ||
| <!-- Upstream WildFly Versions --> | ||
| <upstream.wildfly.version>29.0.0.Final</upstream.wildfly.version> |
There was a problem hiding this comment.
Just a minor note that WildFly 29.0.1.Final was released last week so this could be updated and the Core version below could also be updated to the corresponding 21.1.1.Final version.
There was a problem hiding this comment.
I did it to match EAP8 and ease alignment process.
|
@jfdenise Just FYI, the SAML adapter fixes have been incorporated in this PR. |
fjuma
reviewed
Aug 30, 2023
| @@ -30,13 +30,13 @@ | |||
| <name>App Server - Wildfly</name> | |||
|
|
|||
| <properties> | |||
| <wildfly.version>23.0.2.Final</wildfly.version> | |||
| <wildfly.server.version>23.0.2.Final</wildfly.server.version> | |||
There was a problem hiding this comment.
Should this be updated to a later version?
There was a problem hiding this comment.
As discussed with @pskopek, this is about the test suite and could/should IMHO be a follow up issue.
pedroigor
previously approved these changes
Sep 4, 2023
pedroigor
force-pushed
the
saml-galleon-prod
branch
2 times, most recently
from
16824db
to
09ce401
Compare
ghost
mentioned this pull request
pskopek
force-pushed
the
saml-galleon-prod
branch
from
09ce401
to
69f11b8
Compare
Unreported flaky test detectedIf the below flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.admin.concurrency.ConcurrencyTest#testAllConcurrently |
ghost
reviewed
Sep 5, 2023
pskopek
force-pushed
the
saml-galleon-prod
branch
from
c441e10
to
93fc9b9
Compare
Signed-off-by: Peter Skopek <pskopek@redhat.com>
…buteDefinition#getAttributeMarshaller method Closes keycloak#22593 Signed-off-by: Peter Skopek <pskopek@redhat.com>
Signed-off-by: Peter Skopek <pskopek@redhat.com>
…dules Signed-off-by: Peter Skopek <pskopek@redhat.com>
pskopek
force-pushed
the
saml-galleon-prod
branch
from
93fc9b9
to
2dd9e2c
Compare
ghost
mentioned this pull request
ahus1
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies used in SAML Adapter Galleon Feature Pack need to be aligned with EAP8.
Closes #22823
Closes #22593
Closes #22623
Closes #22172