Set hardcoded user session attribute after IDP first login flow #5306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knutz3n Looks good. Is it possible to add the test for this? I am not sure if we already have the test for Hardcoded UserSession Attribute mapper (Unfortunately we have brokering tests still in both old testsuite (testsuite/integration-deprecated) and new testsuite (testsuite/integration-arquillian). AFAIK FirstBrokerLogin tests are still in the old testsuite) |
|
@mposolda Thanks for the feedback. I checked for tests, but didn't find any existing ones. |
mposolda
approved these changes
Jun 26, 2018
|
@knutz3n Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.