KEYCLOAK-7677 KEYCLOAK-7723 fix version collision of httpclient #5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vramik
changed the title
vramik
force-pushed
the
KEYCLOAK-7677-fix-httpclient-version-colision
branch
2 times, most recently
from
2cbbd1e
to
b1a8c12
Compare
vramik
force-pushed
the
KEYCLOAK-7677-fix-httpclient-version-colision
branch
from
b1a8c12
to
f901680
Compare
hmlnarik
reviewed
Jan 9, 2019
...te/integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/ProfileAssume.java
Outdated
Show resolved
Hide resolved
...integration-arquillian/tests/base/src/main/java/org/keycloak/testsuite/util/OAuthClient.java
Show resolved
Hide resolved
...llian/tests/base/src/test/java/org/keycloak/testsuite/admin/AdminSignatureAlgorithmTest.java
Outdated
Show resolved
Hide resolved
...arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/FineGrainAdminUnitTest.java
Outdated
Show resolved
Hide resolved
...arquillian/tests/base/src/main/java/org/keycloak/testsuite/client/KeycloakTestingClient.java
Outdated
Show resolved
Hide resolved
...tion-arquillian/tests/base/src/test/java/org/keycloak/testsuite/admin/ImpersonationTest.java
Outdated
Show resolved
Hide resolved
...tion-arquillian/tests/base/src/test/java/org/keycloak/testsuite/cookies/CookiesPathTest.java
Outdated
Show resolved
Hide resolved
|
@vramik, could you please incorporate this pedroigor@ef8cf70 to your PR. The If you want I can close your PR and send another preserving your commits, if you don't have time to work on that. |
vramik
force-pushed
the
KEYCLOAK-7677-fix-httpclient-version-colision
branch
2 times, most recently
from
d86ef7a
to
0b44734
Compare
hmlnarik
previously approved these changes
Jan 10, 2019
...tion-arquillian/tests/base/src/test/java/org/keycloak/testsuite/cookies/CookiesPathTest.java
Outdated
Show resolved
Hide resolved
hmlnarik
dismissed
their stale review
The travis failures seem related, could you please check?
vramik
force-pushed
the
KEYCLOAK-7677-fix-httpclient-version-colision
branch
from
0b44734
to
eea938d
Compare
Co-authored-by: Pedro Igor <psilva@redhat.com>
vramik
force-pushed
the
KEYCLOAK-7677-fix-httpclient-version-colision
branch
from
eea938d
to
10486f3
Compare
vramik
changed the title
pedroigor
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.