Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PER_USER leasing strategy to policies #831

Closed
ezekg opened this issue May 2, 2024 · 3 comments · Fixed by #838
Closed

Add a PER_USER leasing strategy to policies #831

ezekg opened this issue May 2, 2024 · 3 comments · Fixed by #838

Comments

@ezekg
Copy link
Member

ezekg commented May 2, 2024

To enforce process limits on a per-user basis. Should only be applied when the process's machine has an owner.

@ezekg
Copy link
Member Author

ezekg commented May 7, 2024

When leasing strategy is set to PER_USER, max machines and max processes should both be per-user.

So it'd look like this:

  • PER_LICENSE: max machines per-license, max processes per-license.
  • PER_MACHINE: max machines per-license, max processes per-machine.
  • PER_USER: max machines per-user, max processes per-user.

@ezekg
Copy link
Member Author

ezekg commented May 7, 2024

How do we handle null machine owners? Should we add a requireMachineOwner attribute that must be enabled before a PER_USER leasing strategy can be used? Or should a null owner be considered a unique user? I lean more towards the latter because I'd like to avoid yet another attribute on the policy object.

@ezekg
Copy link
Member Author

ezekg commented May 7, 2024

Some things that will need to be adjusted for the PER_USER leasing strategy:

  1. Machine limits need to scope per-user, not just per-license, both during machine creation and validations.
  2. Ditto for core limits.

These are not simple changes, but shouldn't be too complex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant