Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(developer): incorrect handling of trailing spaces by GetDelimitedString() in kmcmplib compiler #11937

Closed
1 of 8 tasks
markcsinclair opened this issue Jul 8, 2024 · 0 comments · Fixed by #11938
Closed
1 of 8 tasks

bug(developer): incorrect handling of trailing spaces by GetDelimitedString() in kmcmplib compiler #11937

markcsinclair opened this issue Jul 8, 2024 · 0 comments · Fixed by #11938
Assignees
@markcsinclair
Labels
bug developer/compilers/ developer/
Milestone
A18S7

Comments

@markcsinclair
Copy link
Contributor

markcsinclair commented Jul 8, 2024 •
edited
Loading

Describe the bug

If PKMX_WCHAR GetDelimitedString(PKMX_WCHAR *p, KMX_WCHAR const * Delimiters, KMX_WORD Flags) in Compiler.cpp is supplied with the arguments p=u"(b )", u"()" and GDS_CUTLEAD | GDS_CUTFOLL, although the correct string is returned (b), p is left pointing to the closing delimiter ()) instead of the closing \0.

https://vscode.dev/github/keymanapp/keyman/blob/test/developer/kmcmplib-compiler-unit-tests-2/developer/src/kmcmplib/src/Compiler.cpp#L1686-L1723

Keyman apps

  • Keyman for Android
  • Keyman for iPhone and iPad
  • Keyman for Linux
  • Keyman for macOS
  • Keyman for Windows
  • Keyman Developer
  • KeymanWeb
  • Other - give details at bottom of form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markcsinclair markcsinclair

Labels
bug developer/compilers/ developer/
Projects
None yet
Milestone
A18S7
1 participant
@markcsinclair