Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): Core OSK module #5023

Closed
mcdurdin opened this issue May 3, 2021 · 7 comments
Closed

feat(web): Core OSK module #5023

mcdurdin opened this issue May 3, 2021 · 7 comments
Milestone

Comments

@mcdurdin
Copy link
Member

mcdurdin commented May 3, 2021

This is a holding issue for the Keyman Core integration for Web required to support LDML keyboards. We'll be filling this in as we complete planning and design.

Objective: Rework the Core OSK into a separate module that removes spaghetti integration with element activation.


KeymanWeb:

  • Keyman version: target 15.0
@mcdurdin mcdurdin modified the milestones: 15.0, A15S6 May 3, 2021
@jahorton
Copy link
Contributor

jahorton commented May 11, 2021

Analysis and a potential design specification have now been drafted up in this Google Doc.

Content subject to updates and changes.

@jahorton
Copy link
Contributor

While not quite a standalone module yet, the OSK classes are now far, FAR closer to that end goal. The classes are much more highly modularized as well.

At this stage, I don't think there's a need to make it fully standalone, though this idea may make a nice goal for some point later in the roadmap if desired. My recommendation would be to shift this to the Future milestone for now.

@mcdurdin mcdurdin modified the milestones: A15S14, Future Sep 23, 2021
@srl295 srl295 assigned srl295 and unassigned srl295 Aug 5, 2022
@mcdurdin mcdurdin removed the epic-ldml label Aug 5, 2022
@mcdurdin mcdurdin modified the milestones: Future, 17.0 Dec 9, 2022
@jahorton
Copy link
Contributor

jahorton commented Dec 9, 2022

We should consider #4881 with this.

@jahorton
Copy link
Contributor

jahorton commented Jun 26, 2023

Now that #8560 has merged, we're even closer to this goal.

During the namespace -> module conversion work, I took care to further modularize KMW's OSK. It now has a test page where it is fully operational for user-interaction - though not text output - independently of Keyman Engine for Web. (/web/src/test/manual/web/osk/scratchspace - not the best folder name, but it exists.)

There are still lingering hooks for predictive-text (thus, Web's input-processor) - but refactoring happened to minimize its surfae area, and I believe it possible to this mask for other platforms when we make the final push toward cross-platform use of the OSK module.

@srl295
Copy link
Member

srl295 commented Jun 26, 2023

will there be any new requirements on the ldml side?

@jahorton
Copy link
Contributor

will there be any new requirements on the ldml side?

I doubt it. If memory serves, the plan is to compile the LDML layout specs into standard Keyman touch layouts and the like... so it'd only be the same requirements we're already going to have to deal.

@mcdurdin mcdurdin modified the milestones: 17.0, A17S16 Jul 7, 2023
@mcdurdin
Copy link
Member Author

mcdurdin commented Jul 7, 2023

Modularisation is done, LDML reqs probably not all met but that can be a separate task.

@mcdurdin mcdurdin closed this as completed Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants