Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter proxy vs cache user check can be inconsistent #44

Open
gabriel opened this issue Mar 4, 2021 · 0 comments
Open

Twitter proxy vs cache user check can be inconsistent #44

gabriel opened this issue Mar 4, 2021 · 0 comments

Comments

@gabriel
Copy link
Contributor

gabriel commented Mar 4, 2021

The user cache uses search which enforces single key to user. But the proxy doesn't.
See TestMovedKeyTwitterProxy in https://github.com/keys-pub/keys/blob/master/users/twitter_test.go#L213

This can cause confusion in an edge case where user sigchain fails but the proxy succeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant