Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint files only in staging and not all files #195

Open
kriptonian1 opened this issue Apr 30, 2024 · 5 comments
Open

Lint files only in staging and not all files #195

kriptonian1 opened this issue Apr 30, 2024 · 5 comments
Assignees
@AlexVascon
Labels
good first issue Good for newcomers priority: high scope: general Anything related to this repository type: enhancement New feature or request

Comments

@kriptonian1
Copy link
Contributor

Problem

Currently, if you commit your changes, then our pre commit hook will run linter for all the workspace and all files within the workspace. The problem with this is it run lint on all the file making the process slow.

Solution

Use lint-stage to only lint files that are being staged.
@kriptonian1 kriptonian1 added the good first issue Good for newcomers label Apr 30, 2024
@rajdip-b rajdip-b added the type: enhancement New feature or request label Apr 30, 2024
@AlexVascon
Copy link

Hi @kriptonian1 I am happy to take a look at this for you if that is ok?

@rajdip-b
Copy link
Member

Hey @AlexVascon! That would be superb!

@rajdip-b
Copy link
Member

Assigned to you!

@AlexVascon AlexVascon mentioned this issue May 1, 2024
Closed
6 tasks
@AlexVascon
Copy link

Sorry for the delay. I have made a PR for this issue. Here is a link
@rajdip-b @kriptonian1

@rajdip-b
Copy link
Member

rajdip-b commented May 1, 2024

Awesome! I'll review it ASAP!

@rajdip-b rajdip-b added scope: general Anything related to this repository priority: high labels May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexVascon AlexVascon

Labels
good first issue Good for newcomers priority: high scope: general Anything related to this repository type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Lint and format only staged changes AlexVascon/keyshade
3 participants
@kriptonian1 @AlexVascon @rajdip-b