Admin UI: improved error handling on signin page (#2944)

keystonejs · May 12, 2020 · d60e2ca · d60e2ca
1 parent a124417
commit d60e2ca
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 12 deletions.
diff --git a/.changeset/rich-trees-roll.md b/.changeset/rich-trees-roll.md
@@ -0,0 +1,5 @@
+---
+'@keystonejs/app-admin-ui': patch
+---
+
+Improved error handling on Signin page.
diff --git a/packages/app-admin-ui/client/pages/Signin.js b/packages/app-admin-ui/client/pages/Signin.js
@@ -94,11 +94,7 @@ const SignInPage = () => {
 
   const [signIn, { error, loading, client }] = useMutation(AUTH_MUTATION, {
     variables: { identity, secret },
-    onCompleted: ({ error }) => {
-      if (error) {
-        throw error;
-      }
-
+    onCompleted: () => {
       // Ensure there's no old unauthenticated data hanging around
       client.resetStore();
 
@@ -108,7 +104,7 @@ const SignInPage = () => {
       // Let the server-side redirects kick in to send the user to the right place
       window.location.reload(true);
     },
-    onError: console.error,
+    onError: () => {}, // Remove once a bad password no longer throws an error
   });
 
   const onSubmit = e => {

diff --git a/packages/app-admin-ui/client/pages/Signout.js b/packages/app-admin-ui/client/pages/Signout.js
@@ -55,15 +55,10 @@ const SignedOutPage = () => {
   `;
 
   const [signOut, { loading, client, called }] = useMutation(UNAUTH_MUTATION, {
-    onCompleted: ({ error }) => {
-      if (error) {
-        throw error;
-      }
-
+    onCompleted: () => {
       // Ensure there's no old authenticated data hanging around
       client.resetStore();
     },
-    onError: console.error,
   });
 
   if (!called) {