Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create graphiql shortlinks for multipart forms #1021

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Don't create graphiql shortlinks for multipart forms #1021

merged 1 commit into from
Apr 11, 2019

Conversation

jesstelford
Copy link
Contributor

Trying to do a query with an upload (the Upload type) uses a multi-part form, but our logic expects a JSON POST.

Before this fix, it would throw this error:

TypeError: Cannot read property '0' of undefined
    at gql (/Users/jess/dev/keystone-5/node_modules/graphql-tag/lib/graphql-tag.umd.js:164:69)
    at /Users/jess/dev/keystone-5/packages/server/lib/devQuery.js:37:15

timleslie
timleslie approved these changes Apr 11, 2019
View reviewed changes
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jesstelford jesstelford merged commit b9759f8 into master Apr 11, 2019
@emmatown emmatown deleted the multi-part-no-shortlink branch April 11, 2019 19:57
jesstelford added a commit that referenced this pull request Apr 16, 2019
@jesstelford
Add missing changesets
ff8bc9a 
For #1014, #1015, #1017, #1018, #1021, #1029, #1034
@jesstelford jesstelford mentioned this pull request Apr 16, 2019
Merged
jesstelford added a commit that referenced this pull request Apr 16, 2019
@jesstelford
Add missing changesets (#1035)
ec76b50 
For #1014, #1015, #1017, #1018, #1021, #1029, #1034
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timleslie timleslie timleslie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jesstelford @timleslie