Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up duplicate code in aux list creation #2047

Merged
merged 3 commits into from
Dec 8, 2019

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented Dec 6, 2019

Addresses the main point of #1674, but @timleslie mentioned there was more that needed to be done. Opening for feedback.

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2019

🦋 Changeset is good to go

Latest commit: b0227f5

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@timleslie timleslie self-assigned this Dec 8, 2019
Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good start. I don't think this is enough to close the issue, but it definitely gets us moving in the right direction 👍

@timleslie timleslie merged commit ee6fbcb into keystonejs:master Dec 8, 2019
@github-actions github-actions bot mentioned this pull request Dec 8, 2019
@Vultraz Vultraz deleted the cleanup-create-aux-list branch February 26, 2020 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants