Switched to new @primer/octicons package and regenerated icon components #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: a195f1b We got this. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vultraz
force-pushed
the
updated-arch-icons
branch
from
8a7f47b
to
224174f
Compare
Vultraz
force-pushed
the
updated-arch-icons
branch
from
224174f
to
2ccc767
Compare
Vultraz
commented
Apr 18, 2020
| svgContents = svgContents.replace(/([fill|clip])-rule="/g, '$1Rule="'); | ||
|
|
||
| // FIXME: we don't really want to do this here, but prettier >= 1.18 won't close empty tags anymore... | ||
| svgContents = svgContents.replace(/><\/path>/g, ' />'); |
There was a problem hiding this comment.
Apparently Prettier no longer handles closing the tags. See prettier/prettier#6452. Not sure if we should disable the rule.
There was a problem hiding this comment.
SVG will handle <path/></path> totally fine. It might not be pretty but it's fine.
There was a problem hiding this comment.
Right, but there's currently an eslint rule enabled that will cause the tests to fail if the closing tags are left.
MadeByMike
approved these changes
Apr 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all the new icons that appeared in the process.