Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't save list in Field controllers #2895

Merged
merged 5 commits into from
May 5, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented May 5, 2020

This was unused and all it did was create a circular reference wherein you could access the list which contained the fields from the fields. 馃槤

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2020

馃 Changeset is good to go

Latest commit: 525ca1e

We got this.

This PR includes changesets to release 2 packages
Name Type
@keystonejs/app-admin-ui Minor
@keystonejs/fields Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@timleslie timleslie merged commit 72e0a4e into keystonejs:master May 5, 2020
@github-actions github-actions bot mentioned this pull request May 5, 2020
@Vultraz Vultraz deleted the field-controller-cleanup branch May 6, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants