Fixed Admin UI sometimes using the wrong auth mutation name #2901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: a37ae3a We got this. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced May 6, 2020
Merged
|
Any idea when I could be starting to use @keystonejs/app-admin-ui version 6.0.0 or a release candidate containing the fix? Tried to run my project as a demo project within the Keystone project, but that didn't work out, obviously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2900
The auth provider uses
itemQueryNameto conjugate the mutation name:As seen in the above issue, that's not necessarily always the same as
listKey.This saves a copy of the auth gql names in the strategy which are then passed to the admin meta. Design-wise, it's consistent with how the general CRUD gql names are handled.