Improved/clarified at-tracking date display format #2958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 66c4ebf We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jesstelford
approved these changes
May 13, 2020
|
@Vultraz How does this work, when different users are in different time zones? Do we show timestamps converted to user's local timezone or UTC? |
|
That's a good question, and I'm not entirely sure. Internally, the plugin uses the |
|
Let's use UTC to store the timestamp. Display to be based on user timezone. The timezone of the user can be shown along with the user id field |
This was referenced May 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes this more readable and removes any ambiguity of m/d/y vs d/m/y.
Before:
After:
Am open to tweaking the format if you guys think it should be something different.