Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed React warning about controlled handling in the Float field #2994

Merged
merged 1 commit into from
May 19, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented May 19, 2020

Fixes
image

Also fixes being able to input non-numeric values to the field until it became controlled.

I just copied this block from the Integer and Decimal fields since it's shared by both.

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2020

🦋 Changeset is good to go

Latest commit: 79b3b07

We got this.

This PR includes changesets to release 1 package
Name Type
@keystonejs/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timleslie timleslie merged commit 8fddd97 into keystonejs:master May 19, 2020
This was referenced May 19, 2020
@Vultraz Vultraz deleted the float-field-fix branch May 19, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants