Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client-side is-required input flag to most fields #3007

Merged
merged 2 commits into from
May 21, 2020

Conversation

Vultraz
Copy link
Contributor

@Vultraz Vultraz commented May 21, 2020

See #1270. This doesn't cover all fields, only those using Input, but it's an improvement.

How it looks (the popup appears when submitting with an invalid form. It looks slightly different on Firefox):
image

@changeset-bot
Copy link

changeset-bot bot commented May 21, 2020

🦋 Changeset is good to go

Latest commit: f4a1f29

We got this.

This PR includes changesets to release 2 packages
Name Type
@arch-ui/input Patch
@keystonejs/fields Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Vultraz Vultraz changed the title Added client-side is-required flag to most fields Added client-side is-required input flag to most fields May 21, 2020
@VinayaSathyanarayana
Copy link
Contributor

Will the look and feel of "Required" be customizable?

@Vultraz
Copy link
Contributor Author

Vultraz commented May 21, 2020

Not presently, no. That feels a bit extraneous.

Copy link
Contributor

@timleslie timleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, definitely a move in the right direction 👍

@timleslie timleslie merged commit 04c57fa into keystonejs:master May 21, 2020
@github-actions github-actions bot mentioned this pull request May 21, 2020
@Vultraz Vultraz deleted the fields-client-side-required branch May 21, 2020 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants