Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial support for isIndexed #5616

Merged
merged 6 commits into from
May 5, 2021
Merged

Add initial support for isIndexed #5616

merged 6 commits into from
May 5, 2021

Conversation

timleslie
Copy link
Contributor

@timleslie timleslie commented May 5, 2021

Add an isIndexed config option to the text, integer, float, select, and timestamp field types.

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2021

🦋 Changeset detected

Latest commit: b08b67e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@keystone-next/keystone Minor
@keystone-next/fields Minor
@keystone-next/adapter-prisma-legacy Minor
@keystone-next/test-utils-legacy Patch
@keystone-next/auth Major
@keystone-next/example-auth Patch
@keystone-next/app-basic Patch
@keystone-next/example-ecommerce Patch
keystone-next-app Patch
@keystone-next/example-roles Patch
@keystone-next/example-sandbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 5, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/7sirSszdZm8FL8HqiUVp1sfit4Ht
✅ Preview: https://keystone-next-docs-git-add-is-indexed-keystonejs.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b08b67e:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview May 5, 2021 03:23 Inactive
@vercel vercel bot temporarily deployed to Preview May 5, 2021 03:25 Inactive
@@ -58,6 +60,7 @@ class Field<P extends string> {
this.schemaDoc = schemaDoc;
this.config = config;
this.isRequired = !!isRequired;
this.isIndexed = !!isIndexed;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't you reading isIndexed from the adapter, not the implementation class? So this is doing nothing? but it still works because isIndexed is already set on the adapter class?

@vercel vercel bot temporarily deployed to Preview May 5, 2021 03:41 Inactive
@timleslie timleslie merged commit 3d38946 into master May 5, 2021
@timleslie timleslie deleted the add-is-indexed branch May 5, 2021 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants