Ssgc updates #5667
Ssgc updates #5667
Conversation
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/14qMzL8y8g2WWfT56w51wFpBzEbB |
| @@ -119,7 +119,7 @@ const getItems = async ({ | |||
| }: { | |||
| listKey: string; | |||
| where?: Record<string, any> | null; | |||
| sortBy?: readonly string[] | null; | |||
| orderBy?: readonly Record<string, 'asc' | 'desc'>[] | null; | |||
There was a problem hiding this comment.
This isn't right, the value can be anything, it will often be asc or desc but that is not guaranteed and there are definitely things that will deviate from it (e.g. relations, fields with multiple fields in the db)
There was a problem hiding this comment.
Ah, interesting, what's the correct type here then, is it string, or any?
There was a problem hiding this comment.
just FYI, I haven't made all the GraphQL API changes that we discussed so this will need more changing in the future
Yep, just want to get this close enough to run for now 👍
packages-next/types/src/utils.ts
Outdated
| @@ -9,8 +9,7 @@ export type BaseGeneratedListTypes = { | |||
| readonly search?: string | null; | |||
| readonly first?: number | null; | |||
| readonly skip?: number | null; | |||
| readonly orderBy?: string; | |||
| readonly sortBy?: ReadonlyArray<string> | null; | |||
| readonly orderBy?: ReadonlyArray<Record<string, 'asc' | 'desc'>> | null; | |||
Update the server-side-graphql-library to use the updated GraphQL APIs, unblocking tests which use this API indirectly via the items API.