Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'as' to FieldContainer #5761

Merged
merged 5 commits into from
May 19, 2021
Merged

Add 'as' to FieldContainer #5761

merged 5 commits into from
May 19, 2021

Conversation

gwyneplaine
Copy link
Contributor

@gwyneplaine gwyneplaine commented May 19, 2021

Currently there are quite a few places where we use legend elements to denote field-groups.
None of these are working because the FieldContainer parent is a div, not a fieldset.

This is a minor patch to our ds component, in preparation for incoming a11y fixes in fields.

@vercel
Copy link

vercel bot commented May 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/keystonejs/keystone-next-docs/4P2yPEBqEuJ8GwrTxYKTiFQYTnYh
✅ Preview: https://keystone-next-docs-git-patch-field-container-keystonejs.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2021

🦋 Changeset detected

Latest commit: ac1e341

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@keystone-ui/fields Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gwyneplaine gwyneplaine requested a review from a team May 19, 2021 06:38
@vercel vercel bot temporarily deployed to Preview May 19, 2021 06:39 Inactive
@codesandbox-ci
Copy link

codesandbox-ci bot commented May 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ac1e341:

Sandbox Source
@keystone-next/example-sandbox Configuration

@vercel vercel bot temporarily deployed to Preview May 19, 2021 23:47 Inactive
@gwyneplaine gwyneplaine requested a review from emmatown May 19, 2021 23:48
@vercel vercel bot temporarily deployed to Preview May 19, 2021 23:53 Inactive
@gwyneplaine gwyneplaine enabled auto-merge (squash) May 19, 2021 23:55
@vercel vercel bot temporarily deployed to Preview May 19, 2021 23:56 Inactive
@gwyneplaine gwyneplaine merged commit 3a7acc2 into master May 19, 2021
@gwyneplaine gwyneplaine deleted the patch/field-container branch May 19, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants