fix(deps): update dependency apollo-server-core to v3.10.1 [security] #7812
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.10.0
->3.10.1
GitHub Vulnerability Alerts
GHSA-2fvv-qxrq-7jq6
Impact
The default landing page contained HTML to display a sample
curl
command which is made visible if the full landing page bundle could not be fetched from Apollo's CDN. The server's URL is directly interpolated into this command inside the browser fromwindow.location.href
. On some older browsers such as IE11, this value is not URI-encoded. On such browsers, opening a malicious URL pointing at an Apollo Router could cause execution of attacker-controlled JavaScript.This only affects Apollo Server with the default landing page enabled. Old browsers visiting your server may be affected if ANY of these apply:
plugins
option ofnew ApolloServer
.ApolloServerPluginLandingPageLocalDefault()
orApolloServerPluginLandingPageProductionDefault()
to theplugins
option ofnew ApolloServer
.Browsers visiting your server are NOT affected if ANY of these apply:
ApolloServerPluginLandingPageDisabled()
to theplugins
option ofnew ApolloServer
.ApolloServerPluginLandingPageGraphQLPlayground()
to theplugins
option ofnew ApolloServer
.renderLandingPage
hook to theplugins
option ofnew ApolloServer
.This issue was introduced in v3.0.0 when the landing page feature was added.
Patches
To avoid this, the sample
curl
command has been removed in release 3.10.1.Workarounds
Disabling the landing page removes the possibility of exploit:
See also
A similar issue exists in the landing page of Apollo Router. See the corresponding Apollo Router security advisory.
For more information
If you have any questions or comments about this advisory:
Credits
This issue was discovered by Adrian Denkiewicz of Doyensec.
Release Notes
apollographql/apollo-server
v3.10.1
Compare Source
curl
command which is made visible if the full landing page bundle could not be fetched from Apollo's CDN. The server's URL is directly interpolated into this command inside the browser fromwindow.location.href
. On some older browsers such as IE11, this value is not URI-encoded. On such browsers, opening a malicious URL pointing at an Apollo Router could cause execution of attacker-controlled JavaScript. In this release, the fallback page does not display acurl
command. More details are available at the security advisory.fieldLevelInstrumentation
option toApolloServerPluginUsageReporting
to show that the function may return a number in addition to a boolean. This now matches the implementation and docs. PR #6763Configuration
📅 Schedule: Branch creation - "" in timezone Australia/Sydney, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.