Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id from resolvedData types #7928

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

emmatown
Copy link
Member

@emmatown emmatown commented Sep 15, 2022

This pull request removes id from the new (fixed) resolvedData types (see #7833).

id is not something you can safely change through these interim types, a by product of autoIncrement fields in Prisma not containing an id in the resultant Prisma types.

The types previously were wrong enough that we are not considering this a breaking change, as it only refines our types to be representative of the constraints in effect, and is not a change in behaviour. If you relied on this unsafe behaviour, you can cast away the types at your own peril.

@vercel
Copy link

vercel bot commented Sep 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
keystone-next-docs ✅ Ready (Inspect) Visit Preview Sep 15, 2022 at 6:02AM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

⚠️ No Changeset found

Latest commit: e928280

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dcousens dcousens marked this pull request as ready for review September 15, 2022 05:59
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e928280:

Sandbox Source
@keystone-6/sandbox Configuration

@vercel vercel bot temporarily deployed to Preview September 15, 2022 06:02 Inactive
@emmatown emmatown enabled auto-merge (squash) September 15, 2022 06:03
@emmatown emmatown merged commit f3c1a2b into main Sep 15, 2022
@emmatown emmatown deleted the remove-id-from-resolved-data-types branch September 15, 2022 06:05
dcousens pushed a commit that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants