Restore resolvedData types #7833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 153698d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 153698d:
|
dcousens
force-pushed
the
improve-types-for-prisma-create-update
branch
from
f0b488e
to
926bc79
Compare
dcousens
force-pushed
the
improve-types-for-prisma-create-update
branch
from
926bc79
to
19cd173
Compare
dcousens
force-pushed
the
improve-types-for-prisma-create-update
branch
from
19cd173
to
e24c535
Compare
dcousens
force-pushed
the
improve-types-for-prisma-create-update
branch
2 times, most recently
from
4865517
to
a57d96d
Compare
dcousens
approved these changes
Aug 24, 2022
dcousens
force-pushed
the
improve-types-for-prisma-create-update
branch
from
7b49a2f
to
153698d
Compare
Merged
dcousens
added a commit
that referenced
this pull request
Sep 14, 2022
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
dcousens
added a commit
that referenced
this pull request
Sep 15, 2022
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
dcousens
added a commit
that referenced
this pull request
Sep 15, 2022
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
resolvedDatatypes were identified as being actively misleading in #7801.This pull request restores the types, and now matches what Keystone actually expects and provides to end developers.
The new types approximately mirror the prisma types, but are slightly different for database fields with
kind: 'multi'(multi-column fields) that Keystone and different field types often use.resolvedDatain hooks should use Prisma create/update types #7691