New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix keystone dev
errors for next@^13.4.0
#8568
Conversation
set appDir in next config to be false
This comment was marked as resolved.
This comment was marked as resolved.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@@ -3,6 +3,9 @@ import Path from 'path'; | |||
import withPreconstruct from '@preconstruct/next'; | |||
|
|||
export const config = withPreconstruct({ | |||
experimental: { | |||
appDir: false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder, won't this flag disappear in an upcoming next
patch release? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but if experimental.appDir
drops in an upcoming next
version, we need to resolve this differently.
Users might actually want appDir: true
too (though, this might not affect them if they are doing their own next app)
keystone dev
errors for next@^13.4.0
But this is only for the admin ui, which means that it only affects users that want to use |
Until we have an alternative solution, this is good to go, thanks @MohammadKurjieh |
This resolves: #8553
On next version 13.4.0 and higher setting the appDir to false is mandatory in the next config file.
Ref: vercel/next.js#49261 and vercel/next.js#49251