Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keystone dev errors for next@^13.4.0 #8568

Merged
merged 3 commits into from
May 11, 2023
Merged

Fix keystone dev errors for next@^13.4.0 #8568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2db1a22
fix: :bug: fix crashing on next v13.4.0 and higher
MohammadKurjieh May 10, 2023
51e302c
chore: :memo: added changeset
MohammadKurjieh May 10, 2023
b475047
update changeset
dcousens May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/small-games-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@keystone-6/core': patch
---

Change next `experimental.appDir: false` for now, until resolution found for internal React issues
3 changes: 3 additions & 0 deletions packages/core/src/___internal-do-not-use-will-break-in-patch/admin-ui/next-config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ import Path from 'path';
import withPreconstruct from '@preconstruct/next';

export const config = withPreconstruct({
experimental: {
appDir: false,
Copy link
Member

@dcousens dcousens May 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, won't this flag disappear in an upcoming next patch release? 🤔

},
typescript: {
ignoreBuildErrors: true,
},
Expand Down