-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use console.error for Prisma errors #8722
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e8287e4:
|
bc814a0
to
da4c970
Compare
da4c970
to
e8287e4
Compare
Hmm.. I don't have strong opinions on whether this should be breaking or not, I'm more concerned with direct use of Most apps I've deployed prefer to always log JSON blobs (as Keystone 5 did by default with Basically, I say we should address #7668 before adding more output of any kind. |
This is my thoughts too, and @borisno2 and I are working on that in the background, so I'm happy to park this for now. |
Merging, but we need to address #7668 before release |
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
This pull request changes
KS_PRISMA_ERRORS
to now be logged usingconsole.error
on the server.This isn't a breaking change in any sense, but it might be a change of scope for what users expect from these errors if they output sensitive information.
I am open to feedback on if this is acceptable or not as a
minor
.