Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge previous breaking changes #8776

Merged
merged 5 commits into from Apr 9, 2024
Merged

Merge previous breaking changes #8776

merged 5 commits into from Apr 9, 2024

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Aug 20, 2023

This pull request includes the pull requests that were breaking from 2023, but had since been moved into a major branch.
This is following some confusion that happened when we wanted to do an unexpected patch release last week and our main was polluted with breaking changes.

We had hard reset main to the tag 2023-08-15 (https://github.com/keystonejs/keystone/releases/tag/2023-08-15) and moved any breaking changes into this branch.

We will use a major branch workflow in future, to support changes being easily tracked within the pull requests themselves.

edit: Rebased pull requests listed below

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 20, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0411da:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens
Copy link
Member Author

Rebased on main, updated pnpm-lock in f64a5f6

@dcousens dcousens self-assigned this Aug 30, 2023
@mmachatschek
Copy link
Contributor

@dcousens are there any dates set in stone for when the breaking release is coming?

@dcousens
Copy link
Member Author

dcousens commented Sep 5, 2023

@mmachatschek no, but we are open to hear your feedback if you need it sooner than later.

We know we want at least one more patch release to resolve #8784 before jumping to the next major.

@mmachatschek
Copy link
Contributor

@dcousens we would like to give the RC a go if you guys could merge in the prisma 5.2 release

@mmachatschek
Copy link
Contributor

@dcousens while working on an PR I found this code, https://github.com/keystonejs/keystone/blob/major/packages/core/src/lib/createSystem.ts#L133-L141 I guess this will also be removed in this breaking release?

@dcousens
Copy link
Member Author

dcousens commented Sep 9, 2023

@mmachatschek I don't think removed is right, rename or moved to be .onStartup is the intent.

@mmachatschek
Copy link
Contributor

@dcousens would you mind merging in the main branch so that this branch is clean? I'm continuing work on the #8847 PR and would like to rebase it onto the major branch so it doesn't contain unrelated changes

@dcousens
Copy link
Member Author

dcousens commented Oct 22, 2023

@mmachatschek we're expected to have time to formally allocate to this soon (and other new features), early November.
I'll try to follow up on your request early next week 💙

@gautamsi
Copy link
Member

@dcousens any update on this?

@gautamsi
Copy link
Member

gautamsi commented Apr 2, 2024

any plan to get this going (with latest prisma)? @dcousens

@dcousens
Copy link
Member Author

dcousens commented Apr 5, 2024

@gautamsi I'm actively working on this, stay tuned for an rc asap 💛

dcousens and others added 4 commits April 8, 2024 20:44
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
…nds (#8698)

Author: Pavel White <pahaz.white@gmail.com>
Date:   Mon Aug 14 02:53:50 2023 +0300

Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
@dcousens
Copy link
Member Author

dcousens commented Apr 9, 2024

I rebased the pull requests #8698, #8722 and #8767 - but I had some issues with Prisma 5 (#8693), to keep on moving forward, I am dropping that for now and doing it in a different pull request.

@dcousens dcousens merged commit e382f9e into main Apr 9, 2024
43 checks passed
@dcousens dcousens deleted the major branch April 9, 2024 02:43
@dcousens dcousens changed the title Upcoming Release (breaking) Merge previous breaking changes Apr 9, 2024
@dcousens dcousens mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants