Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds {list}.hooks.validate.[create|update|delete] hooks #9056

Merged
merged 7 commits into from
Mar 6, 2024

Conversation

dcousens
Copy link
Member

@dcousens dcousens commented Mar 6, 2024

This pull request adds hooks.validate.create, hooks.validate.update and hooks.validate.delete for lists.
Part of this work is to verify that we are calling these hooks consistently internally, and that the code is easily reviewed.

The existing code was very fragmented, with mutations/create-update.ts, mutations/delete.ts, mutations/validation.ts, mutations/hooks.ts and mutations/access-control.ts each referencing each other for individual parts of functionality.

This pull request merges all of that functionality into mutations/index.ts, leaving only 1 function in mutations/access-control.ts to be used by the mutations/nested-* functionality which I have still yet to review.

These changes do come with a significant increase in the number of tests for hooks, with 288 tests verifying nearly every combination of hooks I could of think of; with only mixed results needing to be tested from GraphQL.

Copy link

codesandbox-ci bot commented Mar 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8311f65:

Sandbox Source
@keystone-6/sandbox Configuration

@dcousens dcousens merged commit 3d20b94 into main Mar 6, 2024
43 checks passed
@dcousens dcousens deleted the hooks-and-tests branch March 6, 2024 05:47
@dcousens dcousens mentioned this pull request Mar 28, 2024
@gautamsi gautamsi mentioned this pull request Jul 8, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant