Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider testing against Promise A+ spec's conformation tests #2

Open
kevincfz opened this issue Jan 28, 2021 · 0 comments
Open

Consider testing against Promise A+ spec's conformation tests #2

kevincfz opened this issue Jan 28, 2021 · 0 comments

Comments

@kevincfz
Copy link

kevincfz commented Jan 28, 2021

This is an awesome great functional implementation that uses state machine!
Many other implementations use too much repeated if checks.

It would greater if Nancy can pass all the Promise A+ spec tests: https://github.com/promises-aplus/promises-tests

One place where Nancy breaks is when empty then are chained. e.g.

const a = new Nancy((resolve, reject) => {
    setTimeout(() => {
      resolve('123');
    }, 1000);
  })
    .then()
    .then((value) => {
      console.log(value);
    });
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant