Skip to content
This repository has been archived by the owner on Jul 10, 2021. It is now read-only.

Timeout when sending to Growl 2.0 when including binary data #27

Closed
kfdm opened this issue Aug 29, 2012 · 1 comment
Closed

Timeout when sending to Growl 2.0 when including binary data #27

kfdm opened this issue Aug 29, 2012 · 1 comment
Labels

Comments

@kfdm
Copy link
Owner

kfdm commented Aug 29, 2012

Looks like we're not putting on the final crlf when sending messages with binary data.

  File "build/bdist.macosx-10.7-intel/egg/gntp/notifier.py", line 178, in notify
    return self._send('notify', notice)
  File "build/bdist.macosx-10.7-intel/egg/gntp/notifier.py", line 223, in _send
    recv_data = s.recv(1024)
timeout: timed out

I made a gist while testing but I want to make sure to wrap a proper test around this and test against Growl 1.4 and GfW

https://gist.github.com/3514969

@kfdm
Copy link
Owner Author

kfdm commented Aug 29, 2012

As Falkenberg brought up in IRC, need to make sure there's a double crlf after EACH data block. Need to make sure to write a test case around these scenarios so I can get it right.

if you start supporting instances where there would be more than one (icons for notifications during
registration for instance, which 2.0 should support), that would still fail, the first read would go looking for
a double crlf, and not find one till the end of the headers for the next data block, and fail due to that data
block being seemingly too long

@kfdm kfdm closed this as completed in 0e8a6db Sep 4, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant