Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fnml:ReturnMap #12

Closed
samiscoding opened this issue Jan 24, 2023 · 2 comments
Closed

fnml:ReturnMap #12

samiscoding opened this issue Jan 24, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@samiscoding
Copy link
Collaborator

I noticed that in defining the fnml:ReturnMap and fnml:Input we're following a double standard. We're defining the fnml:Input based on both abstract definition in FnO (i.e., parameter) and the practical level (i.e., the reference to the value in the real data source), while, in the case of fnml:ReturnMap we only define based on the abstract level (i.e., we're not allowing the definition of the return value in the real data source). Maybe I'm missing something, otherwise, I think we need to modify the definition of fnml:ReturnMap. Lert me know if you want me to pull request with the modification :)

@samiscoding samiscoding added the documentation Improvements or additions to documentation label Jan 24, 2023
@bjdmeest
Copy link
Member

Hmmm, I don't think I fully understand, because I don't understand why you would want to define the return value in the real data source. If you can define the return value in the real data source, you don't need a function anymore, or what am I missing? Maybe a pull request makes sense to understand the full context?

@samiscoding
Copy link
Collaborator Author

Allowing users to define the name of the output (a field in any type of data source) could increase the reusability of the output without calling the function repeatedly, but I see your points that since the output is connected to the execution, this may not be useful. Unless we can use it when it comes to applying Fields. I guess we can open this issue later once we proceed with Fields if necessary :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants