Upload & View Documents #139
Conversation
Merge master into UploadDOC to use newest UI changes on UploadDOC branch
Merge master into UploadDOC to align with latest changes
Pass className and if TA or student is callin upload document
- Fix metadata bug in UploadDocument.java - Convert URI to Fil in DocumentFragment.java
- Refactor UploadDocument to DocumentServices - Add listDocumentsForClass method - Add "View Documents" fragment and buttons to access that fragment - Option to choose a different file name for upload exists here, but is commented out
| } | ||
|
|
||
|
|
||
| public ArrayList<String> listDcoumentsForClass(String className) { |
There was a problem hiding this comment.
listDcoumentsForClass should be listDocumentsForClass.
There was a problem hiding this comment.
You lost me here... What's the problem?
There was a problem hiding this comment.
Oh I just found the typo, thank you. Will fix in next commit.
|
I am not done reviewing it. But should I be able to download the uploads? There does not seem to be any code in ViewDocumentsFragment that will allow the user to download the documents in that class. |
|
The upload and getting all the list of documents for that class is working. |
|
Having the issue #135 will be quite helpful for this problem. Trying to upload a file without storage permission does not crash the app, but it does not tell the user that the upload was not successful. Since I am still able to choose a file on my device. We can even add a toast in the onError(){...} method in ViewClassPageFragment to display the error not just in our logs but to the user as well |
| @@ -0,0 +1,17 @@ | |||
| <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" | |||
| xmlns:tools="http://schemas.android.com/tools" | |||
| tools:context="com.PocketMoodle.ClassPageFragment" | |||
There was a problem hiding this comment.
The context is more tools:context="com.PocketMoodle.ViewDocumentsFragment" unless u plan to have the list of documents displayed on the ClassPageFragment in the future.
There was a problem hiding this comment.
Good call, I forgot to change that. Thanks!
|
Overall well done. The code is well written, commented and follows syntax. |
|
I'lll need to make a quick change to discussionTest to get travis to approve |
- Change context in fragment_view_documents.xml to appropriate context
|
Committed suggested changes (typo fix, etc.).
No download has been implemented yet, that's next on the roster. |
iamlax
added
discussion-board
upload-document
back-end
front-end
and removed
discussion-board
labels
Please pull and test. This merge adds the following features/modifications:
** Note: Be sure to enable "Storage" permissions for the app!