Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for storage permissions before uploading file #135

Open
kgehmlich opened this issue Apr 1, 2017 · 2 comments
Open

Check for storage permissions before uploading file #135

kgehmlich opened this issue Apr 1, 2017 · 2 comments

Comments

@kgehmlich
Copy link
Owner

Currently, if the app is not granted storage permissions, it crashes when trying to upload a file to the server. A check should be made to ensure that either
a) permissions are modified to grant storage access
or
b) no upload is attempted

@benadavid
Copy link
Collaborator

Can't we set this for everyone in android manifest?

@iamlax
Copy link
Collaborator

iamlax commented Apr 4, 2017

We can set it, but if the user then goes into his setting and changes it the app will crash. Apps still run even if certain permissions are not granted. So just adding the check in a If() condition will prevent a crash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants