Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change assertPositiveDefinite to assertPositiveSemiDefinite #186

Closed
kgoldfeld opened this issue Feb 9, 2023 · 0 comments · Fixed by #199
Closed

Change assertPositiveDefinite to assertPositiveSemiDefinite #186

kgoldfeld opened this issue Feb 9, 2023 · 0 comments · Fixed by #199
Assignees
@kgoldfeld
Labels
bug

Comments

@kgoldfeld
Copy link
Owner

kgoldfeld commented Feb 9, 2023 •
edited
Loading

The current function assertPositiveDefinite currently checks if a matrix is positive semidefinite, so we should really change the name and the error message.
@kgoldfeld kgoldfeld added the bug label Feb 9, 2023
@kgoldfeld kgoldfeld self-assigned this Feb 9, 2023
@kgoldfeld kgoldfeld changed the title Change assertPositiveDefinite to assertSemiPositiveDefinite Change assertPositiveDefinite to assertPositiveSemiDefinite Feb 9, 2023
@kgoldfeld kgoldfeld linked a pull request Apr 7, 2023 that will close this issue
Changing assertPositiveDefinite to assertPositiveSemiDefinite #199
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kgoldfeld kgoldfeld

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changing assertPositiveDefinite to assertPositiveSemiDefinite kgoldfeld/simstudy
1 participant
@kgoldfeld