Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pushover: possibility to use priority argument #72

Closed
vmpr opened this issue Aug 29, 2023 · 4 comments
Closed

pushover: possibility to use priority argument #72

vmpr opened this issue Aug 29, 2023 · 4 comments

Comments

@vmpr
Copy link

vmpr commented Aug 29, 2023

Hi and thanks for your great tool!
I would like to be able to use the priority argument with your pingme tool for pushover, the go wrapper you are using ( https://github.com/gregdel/pushover ) has it already built in, so it should be not a significant effort to implement it into your code, but I can't program go so its hard for me to implement it myself :(
thank you and have a great day!
cheers Ringo

@kha7iq
Copy link
Owner

kha7iq commented Aug 30, 2023

Hello @vmpr
I saw its is available in the wrapper i am using, allow me some time to look into the implementation

@kha7iq
Copy link
Owner

kha7iq commented Nov 23, 2023

Hello @vmpr
I have added the priority flag for pushover, can you build from priority-for-pushover branch and test it.

  1. clone the repo & branch
git clone -b priority-for-pushover https://github.com/kha7iq/pingme.git
  1. cd into the folder
  2. build the binary
go build -o pingme main.go
  1. Send a message
./pingme pushover --token abc --msg "Priority value 1 " --title "Notify" -u xxxxxxx  -p 1

Let me know if this works for you , i will merge it after to main after that.

@vmpr
Copy link
Author

vmpr commented Nov 29, 2023

Hello @kha7iq

I've tested it and it works like a charm! thank you!

cheers Ringo

@kha7iq
Copy link
Owner

kha7iq commented Nov 29, 2023

Thank you for testing.
Changes merged #74
Available in release 0.2.6

@kha7iq kha7iq closed this as completed Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants