Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Exposing fan trigger temperatures as a /sys interface? #39

Closed
davorvr opened this issue Mar 31, 2021 · 4 comments
Closed

Feature - Exposing fan trigger temperatures as a /sys interface? #39

davorvr opened this issue Mar 31, 2021 · 4 comments

Comments

@davorvr
Copy link

davorvr commented Mar 31, 2021

Hello, I would like to be able to change the default fan trigger temperatures (as defined in khadas-fan.c) without having to recompile the kernel on every update. Would it be possible to expose them in /sys, so that they can be modified in the OS? Currently, there does seem to be a fan /sys interface in /sys/class/fan, but the temp file seems to be read-only (it gives an I/O error on write, I assume that it is only meant to provide info for the fan.sh script), without a way to modify the trigger values. Would it be possible to add, for example, files called trig_low, trig_mid and trig_high, each writable, so that we could simply do, for example, echo 90 > /sys/class/fan/trig_high, and similar?

I'm using a VIM3 with the 4.9 kernel.

@numbqq
Copy link
Member

numbqq commented Apr 1, 2021

Hello @davorvr

Yes, of cause, we will add this feature. Thanks for your feedback.

@davorvr
Copy link
Author

davorvr commented Apr 1, 2021

Amazing, thank you!

@numbqq
Copy link
Member

numbqq commented Apr 17, 2021

Added and will release new image in the end of this mounth.

@davorvr
Copy link
Author

davorvr commented Apr 17, 2021

Nice, that was very swift. Thanks again!

@davorvr davorvr closed this as completed Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants