Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sources #130

Merged
merged 17 commits into from
May 19, 2023
Merged

Update sources #130

merged 17 commits into from
May 19, 2023

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented May 17, 2023

  • Inherit from abs.Source in abs_json.Source.
    Correct an error introduced in Update ABS with SDMX-ML support #129. Re-using just one method, instead of subclassing, prevented super() from working in the handle_response() hook.
  • Use https://validator.w3.org/checklink to check broken links in doc/sources.rst
  • Add 4 new sources operated by Eurostat: ESTAT_COMEXT, COMP, EMPL, and GROW.

PR checklist

  • Checks all ✅
  • Update documentation.
  • Update doc/whatsnew.rst.

@khaeru khaeru added the bug label May 17, 2023
@khaeru khaeru self-assigned this May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #130 (f8d9f66) into main (14f6a01) will decrease coverage by 2.47%.
The diff coverage is 76.00%.

@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   98.30%   95.83%   -2.47%     
==========================================
  Files          73       74       +1     
  Lines        5602     5619      +17     
==========================================
- Hits         5507     5385     -122     
- Misses         95      234     +139     
Impacted Files Coverage Δ
sdmx/model/common.py 100.00% <ø> (ø)
sdmx/source/__init__.py 100.00% <ø> (ø)
sdmx/source/estat_comext.py 57.14% <57.14%> (ø)
sdmx/tests/test_sources.py 67.74% <81.25%> (-27.00%) ⬇️
sdmx/source/abs_json.py 100.00% <100.00%> (ø)
sdmx/tests/test_source.py 100.00% <100.00%> (ø)

... and 14 files with indirect coverage changes

@khaeru khaeru changed the title Inherit from abs.Source in abs_json.Source Update sources May 19, 2023
@khaeru khaeru added enh Enhancements & new features data-source Issues related to specific web services/data source(s) labels May 19, 2023
- Remove "documentation" keys: these duplicated doc/sources.rst
- Use consistent format for "header" keys.
- Removed "resources" key, unused and appearing in only one entry.
Update class and attribute docstrings.
@khaeru
Copy link
Owner Author

khaeru commented May 19, 2023

The codecov/patch check failure is due to the added sources, and will be covered by the "services" job run on main.

@khaeru khaeru merged commit f0af35a into main May 19, 2023
@khaeru khaeru deleted the fix/abs-json branch October 11, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug data-source Issues related to specific web services/data source(s) enh Enhancements & new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant