Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split data source tests to a separate workflow #131

Merged
merged 16 commits into from
May 19, 2023
Merged

Split data source tests to a separate workflow #131

merged 16 commits into from
May 19, 2023

Conversation

khaeru
Copy link
Owner

@khaeru khaeru commented May 19, 2023

Currently these tests in sequence and can be very slow; several hours, e.g. here. In this PR:

  • Split the service tests to a separate workflow file.
  • Run each source's tests in a separate job, in parallel.
  • Add a job to collect the results and compile them.
  • Use the term "source" consistently throughout.

PR checklist

  • Checks all ✅
  • Update documentation
  • Update doc/whatsnew.rst

@khaeru khaeru added enh Enhancements & new features data-source Issues related to specific web services/data source(s) ci labels May 19, 2023
@khaeru khaeru self-assigned this May 19, 2023
@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #131 (2f3edfb) into main (f0af35a) will decrease coverage by 0.04%.
The diff coverage is 18.75%.

@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
- Coverage   95.83%   95.80%   -0.04%     
==========================================
  Files          74       74              
  Lines        5619     5622       +3     
==========================================
+ Hits         5385     5386       +1     
- Misses        234      236       +2     
Impacted Files Coverage Δ
sdmx/model/internationalstring.py 100.00% <ø> (ø)
sdmx/tests/test_sources.py 67.37% <0.00%> (-0.37%) ⬇️
sdmx/testing/report.py 43.90% <33.33%> (+0.31%) ⬆️

@khaeru khaeru force-pushed the services-ci branch 2 times, most recently from a72768f to 16aefae Compare May 19, 2023 19:16
@khaeru khaeru force-pushed the services-ci branch 2 times, most recently from 890d805 to 8d55b3c Compare May 19, 2023 20:14
@khaeru khaeru force-pushed the services-ci branch 2 times, most recently from 9bc1f18 to a796e94 Compare May 19, 2023 20:32
@khaeru khaeru temporarily deployed to github-pages May 19, 2023 20:35 — with GitHub Actions Inactive
@khaeru khaeru temporarily deployed to gh-pages May 19, 2023 20:42 — with GitHub Actions Inactive
@khaeru khaeru temporarily deployed to gh-pages May 19, 2023 20:51 — with GitHub Actions Inactive
@khaeru khaeru temporarily deployed to gh-pages May 19, 2023 21:30 — with GitHub Actions Inactive
@khaeru khaeru merged commit 73a9f0e into main May 19, 2023
@khaeru khaeru deleted the services-ci branch May 19, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci data-source Issues related to specific web services/data source(s) enh Enhancements & new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant